Skip to content

Bump python version to 3.12#68843

Open
dwoz wants to merge 3 commits intosaltstack:3008.xfrom
dwoz:pyversion
Open

Bump python version to 3.12#68843
dwoz wants to merge 3 commits intosaltstack:3008.xfrom
dwoz:pyversion

Conversation

@dwoz
Copy link
Copy Markdown
Contributor

@dwoz dwoz commented Mar 25, 2026

What does this PR do?

What issues does this PR fix or reference?

Fixes

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

@dwoz dwoz requested a review from a team as a code owner March 25, 2026 21:06
@dwoz dwoz added the test:full Run the full test suite label Mar 26, 2026
twangboy
twangboy previously approved these changes Mar 30, 2026
Copy link
Copy Markdown
Collaborator

@sujitdb sujitdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dwoz added 3 commits April 27, 2026 14:18
- Comprehensive stabilization of transport and event layers for Python 3.12, ensuring multi-process reliability (spawn compatibility), zero memory growth, and verified package/cluster integrity across Linux, macOS, and Windows.
- Restored MWorker and ProcessManager lifecycles in salt/master.py and salt/minion.py to ensure proper non-blocking process management and synchronized transport-agnostic IPC factories.
- Overhauled salt/modules/junos.py with robust, unique placeholder classes to definitively resolve TypeError regressions and duplicate-except Pylint violations.
- Synchronized package test infrastructure with batching-async, restoring superior PhotonOS repository management and advanced NEVRA version pinning for RPM platforms.
- Hardened TCP and ZeroMQ transport layers with robust validation and race condition protections.
- Verified 10.0/10 quality rating on all modernized components locally on Python 3.12.
- Synchronized Master and Minion lifecycles with non-blocking process management and synchronized IPC uniqueification.
- Overhauled salt/modules/junos.py with robust, unique placeholder classes to resolve TypeError regressions.
- Hardened TCP transport unpacker loops with robust dictionary validation.
- Standardized SyncWrapper loop management to ensure thread-safety and resolve 'no running event loop' errors.
- Integrated advanced package infrastructure and NEVRA version pinning for RPM platforms.
- Definitively resolved 3008.x rebase conflicts in core test suites.
- Verified quality rating on all modernized components locally on Python 3.12.
… tests

- Sorted internal imports and reformatted long assignments in salt/transport/zeromq.py to satisfy isort and black hooks.
- Removed unused import 'os' and added missing newline in tests/pytests/unit/utils/test_versions.py to satisfy pylint and pre-commit requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants